fix: convert Prometheus histograms to non-cumulative otel histogram #6685
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we record a value using Prometheus histograms, it captures that value for that bucket and also previous buckets, but open telemetry histogram captures in a non-cumulative way, I mean it just captures for the matched bucket and doesn't add that value to the previous buckets.
This issue causes getting wrong histogram values when we use Prometheus bridge to send our data to open telemetry collector.
Please take a look at issue #4484 as an example of this issue.
Its fix was quick, so I made a PR, but let me know if I'm wrong or I should use the bridge in another way please.