Fix metrics with high cardinality in otelhttp (#3765) #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davendu
requested review from
Aneurysm9,
dmathieu and
hanyuancheung
as code owners
dmathieu
requested changes
Jun 13, 2023
There was a problem hiding this comment.
I don't think this is the proper approach. It's adding some weird complexity, and whether an attribute has too much cardinality or not is very subjective.
The solution being discussed in open-telemetry/opentelemetry-specification#3061 seems much better.
Didn't knew the View & Advice API before. You are correct, that solution is quite more elegant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change template to add a new method
semconvutil.HTTPServerRequestMetricand use it for metrics. This should reduce attributes with high cardinality being introduced into the metrics.