Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span name generator for otelgin option #3343

Merged

Conversation

jojotong
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3343 (a7d5884) into main (e31186a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3343   +/-   ##
=====================================
  Coverage   69.6%   69.6%           
=====================================
  Files        147     147           
  Lines       6910    6919    +9     
=====================================
+ Hits        4812    4821    +9     
  Misses      1978    1978           
  Partials     120     120           
Impacted Files Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 83.5% <100.0%> (+0.9%) ⬆️
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)

@dmathieu
Copy link
Member

I think this should be named WithSpanNameFormatter, to match the net/http config.
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/net/http/otelhttp/config.go#L189

@jojotong jojotong force-pushed the feat_add_span_name_generator_option branch from a5f2428 to c4a4bf4 Compare January 31, 2023 06:04
@jojotong
Copy link
Contributor Author

I think this should be named WithSpanNameFormatter, to match the net/http config.

Thanks for notice, I've changed to to match the net/http config

@dmathieu
Copy link
Member

dmathieu commented Feb 6, 2023

@jojotong could you fix the tests, lint and add a changelog entry?

@jojotong jojotong force-pushed the feat_add_span_name_generator_option branch 2 times, most recently from 4ecff48 to c05583d Compare February 7, 2023 05:53
@jojotong
Copy link
Contributor Author

jojotong commented Feb 7, 2023

@dmathieu fixed.

@jojotong jojotong force-pushed the feat_add_span_name_generator_option branch from c05583d to 698b74b Compare February 16, 2023 02:27
@jojotong
Copy link
Contributor Author

Rebased to resolve conflicts.

@MadVikingGod MadVikingGod merged commit 9b432ad into open-telemetry:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants