-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add span name generator for otelgin option #3343
add span name generator for otelgin option #3343
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
=====================================
Coverage 69.6% 69.6%
=====================================
Files 147 147
Lines 6910 6919 +9
=====================================
+ Hits 4812 4821 +9
Misses 1978 1978
Partials 120 120
|
I think this should be named WithSpanNameFormatter, to match the net/http config. |
a5f2428
to
c4a4bf4
Compare
Thanks for notice, I've changed to to match the net/http config |
@jojotong could you fix the tests, lint and add a changelog entry? |
4ecff48
to
c05583d
Compare
@dmathieu fixed. |
c05583d
to
698b74b
Compare
Rebased to resolve conflicts. |
No description provided.