Record an exception as an error only when Plug.Exception.status/1 returns 500..599. #165
Conversation
|
I'm good with this, it fits the spec. A little cautious about backwards compatibility, not that we can't change the default, just don't like changing things on people like this. @bryannaegele are you good with this being merged as is? |
|
The spec part is right as far as the error goes but I think we'd still want to record the exception no matter what. |
|
So just not setting |
|
Right. And you don't need to do the status check. Endpoint stop will already take care of marking it errored when it's 500+. Just remove the set error line |
returns 500..599. It is encouraged in the Phoenix docs to use `Plug.Exception` with custom exceptions to generate for example 404 responses at certain places. These 404s should not be marked as error, since simple "route not found" 404s are also not marked as error.
|
Thanks for the feedback. This PR has become very small indeed. Should be good to go now. |
|
@derekkraan Thanks for the fix! |
It is encouraged in the Phoenix docs to use
Plug.Exceptionwith custom exceptions to generate for example 404 responses at certain places. These 404s should not be marked as error, since simple "route not found" 404s are also not marked as error.