Skip to content
This repository has been archived by the owner on Oct 26, 2020. It is now read-only.

replace create_span with start_inactive_span #53

Merged
merged 2 commits into from
May 9, 2020
Merged

replace create_span with start_inactive_span #53

merged 2 commits into from
May 9, 2020

Conversation

tsloughter
Copy link
Member

No description provided.

@tsloughter tsloughter requested a review from a team May 9, 2020 15:09
@tsloughter tsloughter mentioned this pull request May 9, 2020
Merged
ferd
ferd reviewed May 9, 2020
View reviewed changes
Copy link
Member

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that's a spec change? Not too sure why the CI test is failing for elixir there.

@tsloughter
Copy link
Member Author

Right, a spec change. And looks like the elixir test failed for just some build reason, rerunning now.

@tsloughter tsloughter merged commit c03c64e into open-telemetry:master May 9, 2020
@tsloughter tsloughter deleted the start-inactive branch May 9, 2020 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter @ferd