-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move SemanticConventions from shared to API project #6094
move SemanticConventions from shared to API project #6094
Conversation
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, but need to discuss with all maintainers if this is the direction we want to go.
[assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Zipkin" + AssemblyInfo.PublicKey)] | ||
[assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Zipkin.Tests" + AssemblyInfo.PublicKey)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to be discussed by maintainers.
We've historically been hesitant to make internals visible to other libraries.
I understand there's precedence for other Exporters (OTLP and Console and InMemory), but I don't know the longterm plans for the Zipkin Exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed in the 2/4 SIG meeting.
The decision is that InternalsVisibleTo is the wrong direction to go. The fact that internals are visible to other libraries is considered technical debt and the goal is to eventually remove these.
Fixes #
Design discussion issue #
Changes
and leverage internal visible for OpenTelemetry.Exporter.Zipkin.
also reduces the size of the OpenTelemetry.Exporter.Zipkin combo (dll,pdb,xml) by 28k
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes