Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant instrumentations != null checks #6091

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 23, 2025 05:16
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jan 23, 2025
@TimothyMothra
Copy link
Contributor

LGTM.
Need to sync with main.

@SimonCropp
Copy link
Contributor Author

Need to sync with main.

done

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (b508b84) to head (220a6e5).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6091      +/-   ##
==========================================
- Coverage   86.40%   86.39%   -0.02%     
==========================================
  Files         257      257              
  Lines       11649    11632      -17     
==========================================
- Hits        10065    10049      -16     
+ Misses       1584     1583       -1     
Files with missing lines Coverage Δ
src/OpenTelemetry/Logs/LoggerProviderSdk.cs 92.55% <ø> (-0.31%) ⬇️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 93.19% <ø> (-0.12%) ⬇️
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.65% <ø> (+0.32%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants