Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant ?? string.Empty in GetSampler #6078

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

remove redundant ?? string.Empty in GetSampler #6078

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
791bb66
remove redundant ?? string.Empty in GetSampler
SimonCropp Jan 20, 2025
8c1df62
Merge branch 'main' into remove-redundant-string.Empty-in-GetSampler
SimonCropp Jan 22, 2025
f7aeccf
Merge branch 'main' into remove-redundant-string.Empty-in-GetSampler
SimonCropp Jan 23, 2025
88b6893
Merge branch 'main' into remove-redundant-string.Empty-in-GetSampler
SimonCropp Jan 24, 2025
26a3517
Merge branch 'main' into remove-redundant-string.Empty-in-GetSampler
SimonCropp Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenTelemetry/Trace/TracerProviderSdk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@
}

default:
OpenTelemetrySdkEventSource.Log.TracesSamplerConfigInvalid(configValue ?? string.Empty);
OpenTelemetrySdkEventSource.Log.TracesSamplerConfigInvalid(configValue);

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / concurrency-tests / run-concurrency-tests (windows-latest, net8.0, OpenTelemetry.Tests) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / concurrency-tests / run-concurrency-tests (windows-latest, net8.0, OpenTelemetry.Tests) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (ubuntu-22.04, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (ubuntu-22.04, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / concurrency-tests / run-concurrency-tests (windows-latest, net8.0, OpenTelemetry.Api.Tests) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / concurrency-tests / run-concurrency-tests (windows-latest, net8.0, OpenTelemetry.Api.Tests) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (otel-linux-arm64, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / validate-packages / run-package-validation-experimental 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / validate-packages / run-package-validation-experimental 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / validate-packages / run-package-validation-stable 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / validate-packages / run-package-validation-stable 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net8.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-stable / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net462) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.

Check failure on line 450 in src/OpenTelemetry/Trace/TracerProviderSdk.cs

View workflow job for this annotation

GitHub Actions / build-test-project-experimental / build-test (windows-latest, net9.0) 

Possible null reference argument for parameter 'configValue' in 'void OpenTelemetrySdkEventSource.TracesSamplerConfigInvalid(string configValue)'.
break;
}

Expand Down
Loading