Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shims, W3C.Tests] Nullable #5797

Merged
merged 19 commits into from
Sep 16, 2024

Conversation

ysolomchenko
Copy link
Contributor

Towards #3958

Changes

  • Shims.OpenTracing mark as nullable
  • Instumentation.W3cTraceContext.Tests mark as nullable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ysolomchenko ysolomchenko requested a review from a team August 21, 2024 08:04
@github-actions github-actions bot added the pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package label Aug 21, 2024
@ysolomchenko ysolomchenko changed the title mark as nullable [Shims, W3C.Tests] Nullable Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.22%. Comparing base (6250307) to head (c230635).
Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs 69.23% 4 Missing ⚠️
...OpenTelemetry.Shims.OpenTracing/SpanBuilderShim.cs 94.11% 1 Missing ⚠️
src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5797      +/-   ##
==========================================
+ Coverage   83.38%   86.22%   +2.84%     
==========================================
  Files         297      257      -40     
  Lines       12531    11169    -1362     
==========================================
- Hits        10449     9631     -818     
+ Misses       2082     1538     -544     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.95% <82.35%> (?)
unittests-Project-Stable 86.22% <82.35%> (?)
unittests-UnstableCoreLibraries-Experimental 85.71% <82.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...penTelemetry.Shims.OpenTracing/ScopeManagerShim.cs 96.77% <100.00%> (ø)
...OpenTelemetry.Shims.OpenTracing/SpanBuilderShim.cs 90.58% <94.11%> (-0.11%) ⬇️
src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs 91.66% <50.00%> (ø)
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs 80.20% <69.23%> (-1.32%) ⬇️

... and 219 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodeBlanch, could you please also check and merge?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 6, 2024
@Kielek Kielek removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 6, 2024
@@ -32,7 +32,7 @@ internal sealed class SpanBuilderShim : ISpanBuilder
/// <summary>
/// The OpenTelemetry attributes. These correspond to OpenTracing Tags.
/// </summary>
private readonly List<KeyValuePair<string, object>> attributes = new();
private readonly SpanAttributes attributes = new();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CodeBlanch CodeBlanch merged commit 1c01770 into open-telemetry:main Sep 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants