upgraded the build/CI to use net8.0 #4876

Yun-Ting · 2023-09-22T20:42:52Z

Towards #4437
Related to #4868

Changes

Upgraded the build/CI to use the .NET 8 SDK.

Merge requirement checklist

CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
Unit tests added/updated
Appropriate CHANGELOG.md files updated for non-trivial changes
Changes in public API reviewed (if applicable)

codecov · 2023-09-22T20:59:03Z

Codecov Report

Merging #4876 (7db50c3) into main (b22c7a9) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4876      +/-   ##
==========================================
- Coverage   82.95%   82.94%   -0.02%     
==========================================
  Files         294      294              
  Lines       12206    12206              
==========================================
- Hits        10126    10124       -2     
- Misses       2080     2082       +2

Flag	Coverage Δ
unittests	`82.94% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

build/Common.props

...rumentation.W3cTraceContext.Tests/OpenTelemetry.Instrumentation.W3cTraceContext.Tests.csproj

...porter.OpenTelemetryProtocol.Tests/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.csproj

reyang

LGTM to unblock net8 support, I've added few comments but these can be addressed in a follow up PR.

CodeBlanch · 2023-09-30T04:17:33Z

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs

@@ -912,6 +914,7 @@ void ConfigureTestServices(IServiceCollection services)
        Assert.Equal(4, numberofSubscribedEvents);
    }

+#if !NET8_0


Any idea what's going on here? Was something fixed or broken in .NET 8?

CodeBlanch · 2023-09-30T04:18:16Z

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/InProcServerTests.cs

@@ -14,7 +14,7 @@
 // limitations under the License.
 // </copyright>

-#if NET6_0_OR_GREATER
+#if NET6_0 || NET7_0


Same question as above. Any idea what happened here? Seems kind of odd something would change for .NET 8.

@CodeBlanch:
I've updated the code to only run when !OSX || !NET8_0.
#4437 (comment)
I'm still trying to understand why.

What error did you see if we don't make the change? @Yun-Ting

some server error: https://pipelinesghubeus2.actions.githubusercontent.com/qUmkdRTOExOOUcipfw2r74VakBMGn99kKwI1fYYZyOCfUDlpFN/_apis/pipelines/1/runs/117515/signedlogcontent/4?urlExpires=2023-10-02T22%3A16%3A13.0407373Z&urlSigningMethod=HMACV1&urlSignature=ozmqVATdFNoLaQ7QAGD%2BGWhT9sAoEf55qGR5e%2FDrDBQ%3D

These seem to be flaky tests or transient error, which are not specific to TFMs.

I merged this PR but please continue to look into this. I'm worried that we might have stumbled onto a .NET 8 bug and if so we should report it back to the team ASAP!

test/OpenTelemetry.Api.Tests/Trace/TracerTest.cs

...metry.Instrumentation.AspNetCore.Tests/OpenTelemetry.Instrumentation.AspNetCore.Tests.csproj

test/OpenTelemetry.Extensions.Hosting.Tests/OpenTelemetry.Extensions.Hosting.Tests.csproj

test

5c78f38

Yun-Ting added 5 commits September 29, 2023 10:22

Merge branch 'main' into yunl/net8CI

1bff4e7

dummy fix for Run W3C Trace Context docker-compose.integration

f8ec864

add net8.0 to OpenTelemetry.Tests proj

ebde412

add net8.0 to OpenTelemetry.Instrumentation*.Tests.dll (sql??)

7bf3f82

remove 8 from aspnetcore test

df153bd

reyang mentioned this pull request Sep 29, 2023

Update examples to support net8.0 #4902

Merged

Yun-Ting added 7 commits September 29, 2023 12:28

update docker file SDK version

93f4e7c

use Microsoft.AspNetCore.TestHost when targeting net8

5520d90

Microsoft.AspNetCore.Mvc.Testing

eb9a4d1

Merge branch 'main' into yunl/net8CI

a51d664

Merge branch 'main' into yunl/net8CI

0bad326

use new infra

f2103a4

Merge branch 'main' into yunl/net8CI

dba3efe

Yun-Ting changed the title ~~add net8 ci~~ upgraded the build/CI to use net8.0 Sep 29, 2023

Yun-Ting marked this pull request as ready for review September 29, 2023 21:46

Yun-Ting requested a review from a team September 29, 2023 21:46

Yun-Ting added 3 commits September 29, 2023 15:00

PUBLISH_FRAMEWORK=net8.0

adf1ba3

OTLP test docker publish framework to net8

d703ea4

scope down

5c31a55

Yun-Ting mentioned this pull request Sep 29, 2023

.NET 8 build, CI, project targets, etc #4437

Closed

4 tasks

Yun-Ting added 2 commits September 29, 2023 16:40

should fix these test for ubuntu net8 properly in the follow-up prs

ccf9384

preprocessors

3f2437e

xiang17 reviewed Sep 30, 2023

View reviewed changes

build/Common.props Outdated Show resolved Hide resolved

reyang reviewed Sep 30, 2023

View reviewed changes

...rumentation.W3cTraceContext.Tests/OpenTelemetry.Instrumentation.W3cTraceContext.Tests.csproj Outdated Show resolved Hide resolved

reyang reviewed Sep 30, 2023

View reviewed changes

...porter.OpenTelemetryProtocol.Tests/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.csproj Outdated Show resolved Hide resolved

reyang reviewed Sep 30, 2023

View reviewed changes

...porter.OpenTelemetryProtocol.Tests/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.csproj Outdated Show resolved Hide resolved

reyang approved these changes Sep 30, 2023

View reviewed changes

CodeBlanch reviewed Sep 30, 2023

View reviewed changes

Yun-Ting added 7 commits October 2, 2023 09:56

merge main

00f207f

enable net8 for AspNetCore tests

16516c6

os

9e90df3

when !OSX || !NET8_0

bbdcb43

add net8 to tests and update tracertests

e469816

removed conditional compilation !OSX || !NET8_0 for AspNetCore tests

ce5872d

Merge branch 'main' into yunl/net8CI

7db50c3

reyang reviewed Oct 2, 2023

View reviewed changes

test/OpenTelemetry.Api.Tests/Trace/TracerTest.cs Show resolved Hide resolved

CodeBlanch merged commit 8ea6bb9 into open-telemetry:main Oct 2, 2023

Yun-Ting deleted the yunl/net8CI branch October 2, 2023 22:59

vishweshbankwar reviewed Oct 2, 2023

View reviewed changes

...metry.Instrumentation.AspNetCore.Tests/OpenTelemetry.Instrumentation.AspNetCore.Tests.csproj Show resolved Hide resolved

vishweshbankwar reviewed Oct 2, 2023

View reviewed changes

test/OpenTelemetry.Extensions.Hosting.Tests/OpenTelemetry.Extensions.Hosting.Tests.csproj Show resolved Hide resolved

reyang mentioned this pull request Oct 2, 2023

Use TFM specific package version #4911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgraded the build/CI to use net8.0 #4876

upgraded the build/CI to use net8.0 #4876

Yun-Ting commented Sep 22, 2023 •

edited

Loading

codecov bot commented Sep 22, 2023 •

edited

Loading

reyang left a comment

CodeBlanch Sep 30, 2023

CodeBlanch Sep 30, 2023

Yun-Ting Oct 2, 2023 •

edited

Loading

reyang Oct 2, 2023

Yun-Ting Oct 2, 2023 •

edited

Loading

reyang Oct 2, 2023

CodeBlanch Oct 2, 2023

upgraded the build/CI to use net8.0 #4876

upgraded the build/CI to use net8.0 #4876

Conversation

Yun-Ting commented Sep 22, 2023 • edited Loading

Changes

Merge requirement checklist

codecov bot commented Sep 22, 2023 • edited Loading

Codecov Report

reyang left a comment

Choose a reason for hiding this comment

CodeBlanch Sep 30, 2023

Choose a reason for hiding this comment

CodeBlanch Sep 30, 2023

Choose a reason for hiding this comment

Yun-Ting Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

reyang Oct 2, 2023

Choose a reason for hiding this comment

Yun-Ting Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

reyang Oct 2, 2023

Choose a reason for hiding this comment

CodeBlanch Oct 2, 2023

Choose a reason for hiding this comment

Yun-Ting commented Sep 22, 2023 •

edited

Loading

codecov bot commented Sep 22, 2023 •

edited

Loading

Yun-Ting Oct 2, 2023 •

edited

Loading

Yun-Ting Oct 2, 2023 •

edited

Loading