Allow suppressing nested activities without dependency on OTel #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jul 12, 2023
| private readonly SuppressInstrumentationScope? previousScope; | ||
| private bool disposed; | ||
|
|
||
| internal SuppressInstrumentationScope(bool value = true) | ||
| { | ||
| this.previousScope = Slot.Get(); | ||
| this.Depth = value ? -1 : 0; | ||
| this.Depth = (value || (this.previousScope == null && IsSuppressedWithActivityProperty())) ? -1 : 0; |
There was a problem hiding this comment.
We'll need perf numbers like #1049
reyang
requested changes
Jul 12, 2023
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates approach proposed in #4641
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes