Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] Update preprocessor directives in Jaeger thrift code #4349

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 30, 2023

Changes

  • Updates preprocessor directives in Jaeger thrift code to be aware of the net6.0 target.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team March 30, 2023 18:17
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #4349 (9b0fdc0) into main (533513f) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4349      +/-   ##
==========================================
+ Coverage   84.66%   84.71%   +0.04%     
==========================================
  Files         298      298              
  Lines       11971    11983      +12     
==========================================
+ Hits        10135    10151      +16     
+ Misses       1836     1832       -4     
Impacted Files Coverage Δ
...er.Jaeger/ApacheThrift/Protocol/TBinaryProtocol.cs 79.56% <ø> (+0.68%) ⬆️
...r.Jaeger/ApacheThrift/Protocol/TCompactProtocol.cs 79.76% <ø> (+0.49%) ⬆️
...Exporter.Jaeger/ApacheThrift/Protocol/TProtocol.cs 92.15% <ø> (+0.85%) ⬆️

... and 4 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit a274f06 into open-telemetry:main Mar 30, 2023
@CodeBlanch CodeBlanch deleted the jaeger-preprocessor-fixes branch March 30, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants