Refactor OpenTelemetry.Extensions.Hosting readme #4179
Conversation
| [IServiceCollection](https://learn.microsoft.com/dotnet/api/microsoft.extensions.dependencyinjection.iservicecollection). | ||
|
|
||
| These methods were marked obsolete and later removed. You should migrate your | ||
| code to the new `AddOpenTelemetry` method documented above. |
There was a problem hiding this comment.
i wonder if we should give an example startup code for this? or the PR which did this for our example one? or maybe link to old and new version of our example app?
There was a problem hiding this comment.
We could link to #4071 where there are some migration steps.
There was a problem hiding this comment.
We could link to #4071 where there are some migration steps.
oops didn't see this comment before I updated it. I just added links to the old (1.3.2 version) and new (main). What do you all think?
| @@ -21,8 +21,6 @@ and metrics (`MeterProvider`) in [ASP.NET | |||
|
|
|||
| ## Extension method reference | |||
|
|
|||
| ### Current OpenTelemetry SDK v1.4.0 and newer extensions | |||
There was a problem hiding this comment.
consider a link to the example app, which shows this in action.
There was a problem hiding this comment.
There is a usage section below just not shown on the diff unless you expand it
There was a problem hiding this comment.
Or if you are saying in addition to that a link would be good, find by me 😄
There was a problem hiding this comment.
yea on top of the basic usage shown here.
There was a problem hiding this comment.
the example, if followed correctly, will help avoid mistakes like adding ActivitySource to DI etc. So good to link from this
No description provided.