Support customized OTLP endpoint for log example #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
reviewed
Jan 9, 2023
Comment on lines
+79
to
+82
| if (!string.IsNullOrWhiteSpace(options.Endpoint)) | ||
| { | ||
| otlpOptions.Endpoint = new Uri(options.Endpoint); | ||
| } |
There was a problem hiding this comment.
Hmm, I guess TestMetrics.cs is also missing this functionality. At a minimum, probably makes sense to add it there too. Though, seems like there may be an opportunity to share some code between these examples, but maybe makes sense to consider that separately.
There was a problem hiding this comment.
Added the same Endpoint command line option to metrics example. I did some minor cleanup to remove dup code, but agree that further cleanup could be done separately.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
=======================================
Coverage 85.61% 85.62%
=======================================
Files 289 289
Lines 11255 11255
=======================================
+ Hits 9636 9637 +1
+ Misses 1619 1618 -1
|
Kielek
approved these changes
Jan 10, 2023
reyang
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The current OTLP example doesn't accept endpoint from command line. This PR add the support following the convention from OTLP trace/metrics exporter.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes