[Logs] Remove ConfigureResource on OpenTelemetryLoggingOptions #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3999 +/- ##
==========================================
+ Coverage 85.40% 85.43% +0.03%
==========================================
Files 289 289
Lines 11236 11233 -3
==========================================
+ Hits 9596 9597 +1
+ Misses 1640 1636 -4
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3999 +/- ##
==========================================
+ Coverage 85.40% 85.45% +0.04%
==========================================
Files 289 289
Lines 11236 11233 -3
==========================================
+ Hits 9596 9599 +3
+ Misses 1640 1634 -6
|
utpilla
approved these changes
Dec 9, 2022
pjanotti
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Dec 13, 2022
* Bump OTel to 1.4.0-rc.1 * ConfigureResource api was removed in open-telemetry/opentelemetry-dotnet#3999 * Update limits based on open-telemetry/opentelemetry-dotnet#3978 * Fix build structure OpenTelemetry references OpenTelemetry.Extensions.DependencyInjection package * Fix ModuleTests * Handle AspNetCore metrics changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3307
Changes
We decided during API review of 1.4 to remove the
ConfigureResourceAPI on logs. This is a good API but we know big changes are coming to logs. In themain-logsbranch this method has already been obsoleted and moved ontoLoggerProviderBuilder. The goal is to bring this back soon. In the meantime, the existingSetResourceBuilderworks just as well.TODOs
CHANGELOG.mdupdated for non-trivial changes