Fix ConsoleExporter fails silently when exporting an ActivityLink without Tags.
#3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Nov 22, 2022
reyang
reviewed
Nov 22, 2022
reyang
reviewed
Nov 22, 2022
reyang
reviewed
Nov 22, 2022
test/OpenTelemetry.Tests/Shared/VerifyNoEventSourceErrorsLoggedTestAttribute.cs
Outdated
Show resolved
Hide resolved
reyang
previously requested changes
Nov 22, 2022
CodeBlanch
reviewed
Nov 22, 2022
| @@ -116,11 +116,14 @@ public override ExportResult Export(in Batch<Activity> batch) | |||
| foreach (var activityLink in activity.Links) | |||
| { | |||
| this.WriteLine($" {activityLink.Context.TraceId} {activityLink.Context.SpanId}"); | |||
| foreach (var attribute in activityLink.Tags) | |||
There was a problem hiding this comment.
@TimothyMothra FYI you could re-write this as:
foreach (ref readonly var attribute in activityLink.EnumerateTagObjects())More efficient and it will handle the null case for you 😄
Might be worth re-writing all of the foreach loops in here to use the newer pattern just to have a good reference doing it correctly. Follow-up thing if you are interested 😉
There was a problem hiding this comment.
I'll take this as a follow up after this PR merges. :)
CodeBlanch
reviewed
Nov 22, 2022
…orter in try/catch
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3932 +/- ##
==========================================
+ Coverage 85.30% 85.50% +0.19%
==========================================
Files 287 288 +1
Lines 11026 11059 +33
==========================================
+ Hits 9406 9456 +50
+ Misses 1620 1603 -17
|
reyang
reviewed
Nov 22, 2022
test/OpenTelemetry.Exporter.Console.Tests/ConsoleActivityExporterTest.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 22, 2022
test/OpenTelemetry.Exporter.Console.Tests/ConsoleActivityExporterTest.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 22, 2022
test/OpenTelemetry.Exporter.Console.Tests/ConsoleActivityExporterTest.cs
Outdated
Show resolved
Hide resolved
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
utpilla
reviewed
Nov 28, 2022
test/OpenTelemetry.Exporter.Console.Tests/ConsoleActivityExporterTest.cs
Show resolved
Hide resolved
utpilla
approved these changes
Nov 28, 2022
Kielek
approved these changes
Dec 7, 2022
utpilla
reviewed
Dec 7, 2022
utpilla
reviewed
Dec 7, 2022
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Bug fix, ConsoleExporter fails silently when exporting an `ActivityLink` | |||
There was a problem hiding this comment.
nit: Reword this to something like:
Bug fix to prevent ConsoleExporter from failing when exporting an ActivityLink without tags.
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3863 .
ConsoleExporter fails silently when exporting an
ActivityLinkwithout Tags.Changes
ConsoleActivityExporterConsoleActivityExporterTestto reproduce reported issueBecause the new test project has
nullable enable, the Utils class needed to be fixed.I used
Debug.Assertto check for null and used the null-forgiving operator to dismiss the build error.Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes