Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit fixes to prometheus asp.net core #3511

Conversation

cijothomas
Copy link
Member

part 2 of #3510

@cijothomas cijothomas requested a review from a team August 1, 2022 18:12
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #3511 (04548bd) into main (084244c) will increase coverage by 0.10%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
+ Coverage   86.67%   86.77%   +0.10%     
==========================================
  Files         275      275              
  Lines        9970     9963       -7     
==========================================
+ Hits         8641     8645       +4     
+ Misses       1329     1318      -11     
Impacted Files Coverage Δ
.../PrometheusExporterApplicationBuilderExtensions.cs 100.00% <ø> (ø)
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <ø> (ø)
...metheus.AspNetCore/PrometheusExporterMiddleware.cs 67.85% <ø> (ø)
...Prometheus.AspNetCore/PrometheusExporterOptions.cs 50.00% <ø> (ø)
...Listener/Internal/PrometheusExporterEventSource.cs 27.77% <ø> (ø)
...heus.HttpListener/Internal/PrometheusSerializer.cs 78.21% <ø> (ø)
...s.HttpListener/Internal/PrometheusSerializerExt.cs 100.00% <ø> (ø)
...theusHttpListenerMeterProviderBuilderExtensions.cs 58.33% <66.66%> (ø)
...rometheusExporterMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <100.00%> (ø)
... and 6 more

@cijothomas cijothomas merged commit 0187a2a into open-telemetry:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants