Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Bucket Histogram - part 7 #3499

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 27, 2022

Following #3462.

Changes

  • Hammered out the ExponentialBucketHistogram ctor.
  • Added more tests on scale -10 and -11
  • Added tests for Zeros, Infinities and NaNs.

@reyang reyang requested a review from a team July 27, 2022 23:06
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #3499 (48ce16b) into main (6789efa) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
- Coverage   86.30%   86.21%   -0.09%     
==========================================
  Files         270      270              
  Lines        9865     9867       +2     
==========================================
- Hits         8514     8507       -7     
- Misses       1351     1360       +9     
Impacted Files Coverage Δ
...penTelemetry/Metrics/ExponentialBucketHistogram.cs 58.49% <50.00%> (+17.31%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 50.00% <0.00%> (-28.58%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 59.09% <0.00%> (-18.19%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 75.00% <0.00%> (-10.00%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-4.45%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.20% <0.00%> (-3.30%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <0.00%> (+2.53%) ⬆️

@cijothomas cijothomas merged commit 25cfa17 into open-telemetry:main Jul 27, 2022
@reyang reyang deleted the reyang/exp7 branch July 29, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants