Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied the dependency injection pattern to OtlpExporter #1942

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 27, 2021

Changes

Applied the dependency injection pattern from #1889 to OtlpExporter.

TODOs

  • CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team March 27, 2021 04:48
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #1942 (89bb51b) into main (5bf2b42) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
- Coverage   83.67%   83.55%   -0.12%     
==========================================
  Files         192      192              
  Lines        6167     6172       +5     
==========================================
- Hits         5160     5157       -3     
- Misses       1007     1015       +8     
Impacted Files Coverage Δ
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 72.22% <33.33%> (-20.09%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️

@cijothomas cijothomas merged commit efe2d96 into open-telemetry:main Mar 29, 2021
@CodeBlanch CodeBlanch deleted the otlp-exporter-dependencyinjection branch April 18, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants