Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1397.
Changes
Stores Resource on each Activity as a tag instead of as a custom property. This is to avoid an allocation on every Activity currently done to store Resource as a custom property.
This is by far the most expensive option from a performance perspective. We store Resource on every Activity. You have to enumerate on tags to retrieve it. And then you have to exclude the resource tag from being written out with other tags during export. Not a huge hit, but the other options avoid it all.
Also, every Exporter would have to know to exclude the special
otel.resource
tag. We could document to exclude all "otel.*" tags, but that carries an even more expensive comparison while looping, even bigger perf hit.TODOs:
CHANGELOG.md
updated for non-trivial changes