Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed AddOpenTelemetryTracing method which takes Func returning TracerProvider #1456

Merged

Conversation

cijothomas
Copy link
Member

Changes

Removed public API methods which are not required, and can potentially cause confusion.
AddOpenTelemetryTracing taking Action to configure TracerProviderBuilder can be used instead of the ones which take Func returning TracerProvider itself. The later requires the caller to call .Build(), while the former does it automatically. Have these 2 APIs can be confusing.

(Note: There are more changes coming to hosting to address other open issues.)

Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team November 4, 2020 09:29
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1456 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
+ Coverage   81.72%   81.75%   +0.03%     
==========================================
  Files         229      229              
  Lines        6095     6095              
==========================================
+ Hits         4981     4983       +2     
+ Misses       1114     1112       -2     
Impacted Files Coverage Δ
...ensions.Hosting/OpenTelemetryServicesExtensions.cs 75.60% <ø> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+8.82%) ⬆️

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 38e058f into open-telemetry:master Nov 4, 2020
@cijothomas cijothomas deleted the cijothomas/hostingcleanup1 branch November 4, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants