Fix build and reuse scopes

open-telemetry · Nov 29, 2023 · f8ee51b · f8ee51b
1 parent 44eaa4d
commit f8ee51b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/PrometheusAspNetCoreOptions.cs b/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/PrometheusAspNetCoreOptions.cs
@@ -43,7 +43,7 @@ public int ScrapeResponseCacheDurationMilliseconds
     }
 
     /// <summary>
-    /// Gets or sets the ability to export metric scope info. Default value: true.
+    /// Gets or sets a value indicating whether to export metric scope info. Default value: true.
     /// </summary>
     public bool ScopeInfoEnabled
     {

diff --git a/src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusCollectionManager.cs b/src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusCollectionManager.cs
@@ -27,6 +27,7 @@ internal sealed class PrometheusCollectionManager
     private readonly int scrapeResponseCacheDurationMilliseconds;
     private readonly Func<Batch<Metric>, ExportResult> onCollectRef;
     private readonly Dictionary<Metric, PrometheusMetric> metricsCache;
+    private readonly HashSet<string> scopes;
     private int metricsCacheCount;
     private byte[] buffer = new byte[85000]; // encourage the object to live in LOH (large object heap)
     private int globalLockState;
@@ -42,6 +43,7 @@ public PrometheusCollectionManager(PrometheusExporter exporter)
         this.scrapeResponseCacheDurationMilliseconds = this.exporter.ScrapeResponseCacheDurationMilliseconds;
         this.onCollectRef = this.OnCollect;
         this.metricsCache = new Dictionary<Metric, PrometheusMetric>();
+        this.scopes = new HashSet<string>();
     }
 
 #if NET6_0_OR_GREATER
@@ -184,17 +186,17 @@ private ExportResult OnCollect(Batch<Metric> metrics)
         {
             if (this.exporter.ScopeInfoEnabled)
             {
-                var scopes = new HashSet<string>();
+                this.scopes.Clear();
 
                 foreach (var metric in metrics)
                 {
                     if (PrometheusSerializer.CanWriteMetric(metric))
                     {
-                        scopes.Add(metric.MeterName);
+                        this.scopes.Add(metric.MeterName);
                     }
                 }
 
-                foreach (var scope in scopes)
+                foreach (var scope in this.scopes)
                 {
                     try
                     {

diff --git a/src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusExporterOptions.cs b/src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusExporterOptions.cs
@@ -43,7 +43,7 @@ public int ScrapeResponseCacheDurationMilliseconds
     }
 
     /// <summary>
-    /// Gets or sets the ability to export metric scope info. Default value: true.
+    /// Gets or sets a value indicating whether to export metric scope info. Default value: true.
     /// </summary>
     public bool ScopeInfoEnabled { get; set; } = true;
 }