Modify shell scripts to pass shellcheck --severity=warning

[johnbley]

Got all the shell scripts to pass shellcheck --severity=warning and added a CI step to ensure it stays that way.
The fixes were mostly the usual quoting rules. One additional change was that I modified the instrument scripts to exec the original script rather than run it as a subprocess. This is the standard way we do it in the lambda instrumentation

[johnbley]

Test failures appear unrelated:

error NU1902: Warning As Error: Package 'OpenTelemetry.Instrumentation.Http' 1.8.0 has a known moderate severity vulnerability

[Kielek]

Test failures appear unrelated:

error NU1902: Warning As Error: Package 'OpenTelemetry.Instrumentation.Http' 1.8.0 has a known moderate severity vulnerability

Should be fixed by #3372 shortly.

[Kielek]

One more things. CI converts https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/script-templates/otel-dotnet-auto-install.sh.template to the final sh file by executing BuildInstallationScripts nuke steps. I think, this file should also be covered by the shellcheck.

[johnbley]

One more things. CI converts https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/script-templates/otel-dotnet-auto-install.sh.template to the final sh file by executing BuildInstallationScripts nuke steps. I think, this file should also be covered by the shellcheck.

👍 I added *.sh.template to the CI step.