MySqlConnector - traces instrumentation #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgrainger fyi, |
RassK
approved these changes
Jun 21, 2023
Kielek
commented
Jun 21, 2023
| metricsexporter | ||
| mkdir | ||
| mktemp | ||
| MSMQ | ||
| myapp | ||
| MYSQLCONNECTOR |
There was a problem hiding this comment.
This line is only important change. Other are from auto-order by VSCode
pellared
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #2636
What
MySqlConnector - traces instrumentation
Tests
CI + tested locally on Windows with Docker Desktop on Linux
Checklist
CHANGELOG.mdis updated.Notes
Some improvements related to handling status mysql-net/MySqlConnector#1334.
As otel-semantic is going through stabilization process I expect some changes in tags and tag values (for sure for network park shortly).