Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gac info to docs #1986

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

pjanotti
Copy link
Contributor

Why

Add more information about the GAC usage by automatic instrumentation.

Fixes #1906

What

  • Added a short sentence to the design doc about assembly redirection on the .NET Framework.
  • Retroactively updating the release notes when GAC install/uninstall was added (at this time this is more for us to easily track when that was done, I'm not planning to change the tagged branch for the release).
  • Added a more verbose section to the troubleshooting describing when GAC install comes into play.

Tests

N/A

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
    - [ ] New features are covered by tests.

@pjanotti pjanotti requested a review from a team January 12, 2023 23:24
Retroactive CHANGELOG.md note for GAC registration

Add GAC info to design and troubleshooting docs

Fix line too long
docs/troubleshooting.md Outdated Show resolved Hide resolved
docs/troubleshooting.md Outdated Show resolved Hide resolved
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple nits.

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@pellared pellared enabled auto-merge (squash) January 13, 2023 12:47
@pellared pellared merged commit a684cd6 into open-telemetry:main Jan 13, 2023
@pjanotti pjanotti deleted the add-gac-info-to-docs branch January 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAC - install and uninstall clarification
4 participants