[repo] Fix netcoreapp3.1 tests failing in CI #827
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
=======================================
Coverage 77.87% 77.88%
=======================================
Files 176 176
Lines 5301 5303 +2
=======================================
+ Hits 4128 4130 +2
Misses 1173 1173
|
github-actions
bot
requested review from
cijothomas,
mic-max,
reyang,
utpilla and
Yun-Ting
| @@ -89,6 +91,11 @@ public ProcessMetrics(ProcessInstrumentationOptions options) | |||
| description: "Process threads count."); | |||
| } | |||
|
|
|||
| public void Dispose() | |||
| { | |||
| this.meterInstance.Dispose(); | |||
There was a problem hiding this comment.
I'm not sure if it's safe to do this in a scenario where you have multiple Sdks each with an instance of ProcessMetrics added since they would be using the same Meter name (even though each instance of ProcessMetrics would create a new instance of Meter).
There was a problem hiding this comment.
I added a test and yes, it does appear to be an issue 😭 Going to disable the test for now. I think multiple provider case is rare so it isn't super urgent that we fix this. But I'm going to spin up an issue and work with @Yun-Ting on it.
| @@ -40,7 +40,7 @@ public void AutoFlushActivityProcessor_FlushAfterLocalServerSideRootSpans_EndMat | |||
|
|
|||
| using var source = new ActivitySource(sourceName); | |||
| using var activity = source.StartActivity("name", ActivityKind.Server); | |||
| activity.Dispose(); | |||
| activity.Stop(); | |||
Additional changes: