Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.MassTransit] deprecate package + remove code #788

Merged
merged 10 commits into from
Jan 17, 2023
Merged

[Instrumentation.MassTransit] deprecate package + remove code #788

merged 10 commits into from
Jan 17, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 22, 2022 •
edited
Loading

Replaces #779.

Changes

Deprecate MassTransit.
Add information how to instrument MassTransit 8.0.0+.
Remove MassTransit code.

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #

@Kielek Kielek added the comp:instrumentation.masstransit Things related to OpenTelemetry.Instrumentation.MassTransit label Nov 22, 2022
@Kielek Kielek force-pushed the deprecate-masstransit branch from 725fa53 to 836bbbe Compare November 22, 2022 10:09
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #788 (92ab77d) into main (6cafab9) will increase coverage by 9.87%.
The diff coverage is n/a.

❗ Current head 92ab77d differs from pull request most recent head 5aac90f. Consider uploading reports for the commit 5aac90f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   68.88%   78.76%   +9.87%     
==========================================
  Files         188      176      -12     
  Lines        7081     5485    -1596     
==========================================
- Hits         4878     4320     -558     
+ Misses       2203     1165    -1038
Impacted Files Coverage Δ
...etry.Exporter.Instana/Implementation/SpanSender.cs 61.53% <0.00%> (-7.70%) ⬇️
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <0.00%> (ø)
...r.Stackdriver/Implementation/ActivityExtensions.cs 75.00% <0.00%> (ø)
...etry.Exporter.Geneva/TLDExporter/TldLogExporter.cs
...lemetry.Exporter.Geneva/TLDExporter/TldExporter.cs
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs
...ry.Exporter.Geneva/External/TraceLoggingDynamic.cs
...orter.Geneva/TLDExporter/UncheckedASCIIEncoding.cs
...etry.Exporter.Geneva/TLDExporter/JsonSerializer.cs
...ter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs 92.92% <0.00%> (+0.50%) ⬆️
... and 5 more

@Kielek
Copy link
Contributor Author

Kielek commented Nov 22, 2022

@phatboyg, @alexvaluyskiy FYI

@Kielek Kielek marked this pull request as ready for review November 22, 2022 10:27
@Kielek Kielek requested a review from a team November 22, 2022 10:27
phatboyg
phatboyg approved these changes Nov 22, 2022
View reviewed changes
Copy link

@phatboyg phatboyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you!

@utpilla utpilla changed the title [Instrumenation.MassTransit] deprecate package + remove code [Instrumentation.MassTransit] deprecate package + remove code Nov 23, 2022
@Kielek Kielek mentioned this pull request Nov 24, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 7, 2022
@Kielek Kielek removed the Stale label Dec 7, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 15, 2022
@Kielek Kielek removed the Stale label Dec 15, 2022
@RagingKore
Copy link

Interesting, I would still leave an extension to simply add the source in a typed way.
Thoughts? @phatboyg

@phatboyg
Copy link

A typed way? It's literally AddSource("MassTransit") on the OTEL configuration. What would be typed about it?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 23, 2022
@Kielek Kielek removed the Stale label Dec 27, 2022
@Kielek Kielek mentioned this pull request Jan 3, 2023
Closed
3 tasks
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 17, 2023
@Kielek Kielek removed the Stale label Jan 17, 2023
@cijothomas cijothomas merged commit bdf15ef into open-telemetry:main Jan 17, 2023
@reyang reyang mentioned this pull request Feb 1, 2023
Closed
1 task
@Kielek Kielek deleted the deprecate-masstransit branch May 10, 2023 14:23
@Kielek Kielek mentioned this pull request Jun 30, 2023
Closed
2 tasks
@austindrenski austindrenski mentioned this pull request Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

@phatboyg phatboyg phatboyg approved these changes

Assignees
No one assigned
Labels
comp:instrumentation.masstransit Things related to OpenTelemetry.Instrumentation.MassTransit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kielek @RagingKore @phatboyg @cijothomas @reyang