[Instrumentation.Hangfire] Added support for custom job display names

[prochnowc]

Fixes #755.

Changes

Adds support for using custom display names in the activities display name.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: prochnowc / name: Christian Prochnow (fad3a02)

[Kielek]

@fred2u, could you please check?

[Kielek]

@prochnowc, for sure we need entry in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.Hangfire/CHANGELOG.md

[prochnowc]

@prochnowc, for sure we need entry in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.Hangfire/CHANGELOG.md

@Kielek I wasnt sure where to put it .. is an entry below "Unreleased" suitable?

[Kielek]

@prochnowc, for sure we need entry in https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.Hangfire/CHANGELOG.md

@Kielek I wasnt sure where to put it .. is an entry below "Unreleased" suitable?

Yes, you can find example here:

opentelemetry-dotnet-contrib/src/OpenTelemetry.Contrib.Instrumentation.AWS/CHANGELOG.md

Lines 3 to 8 in 8f7fbd4

	## Unreleased
	* Fixed issue when using version 3.7.100 of the AWS SDK for .NET triggering an
	EndpointResolver not found exception.
	([#726](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/726))

[prochnowc]

Yes, you can find example here:

opentelemetry-dotnet-contrib/src/OpenTelemetry.Contrib.Instrumentation.AWS/CHANGELOG.md

Lines 3 to 8 in 8f7fbd4

	## Unreleased
	* Fixed issue when using version 3.7.100 of the AWS SDK for .NET triggering an
	EndpointResolver not found exception.
	([#726](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/726))

@Kielek Ok, added the entry to CHANGELOG

[prochnowc]

@fred2u The failing builds are related to System.Diagnostics.DiagnosticSource 7.0.0-rc.1.22426.10 which complains about not supporting netcoreapp3.1 - I was already wondering why OpenTelemetry uses 7.0.0-rc instead of 6.0.0 ?

The build will probably fail for the same reason with v6.

[cijothomas]

@fred2u The failing builds are related to System.Diagnostics.DiagnosticSource 7.0.0-rc.1.22426.10 which complains about not supporting netcoreapp3.1 - I was already wondering why OpenTelemetry uses 7.0.0-rc instead of 6.0.0 ?

The build will probably fail for the same reason with v6.

^ That is only a warning and not an error. Build fails for different reason.

C:\Users\runneradmin.nuget\packages\system.diagnostics.diagnosticsource\7.0.0-rc.1.22426.10\buildTransitive\netcoreapp2.0\System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0-rc.1.22426.10 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set true in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.Process.Tests\OpenTelemetry.Instrumentation.Process.Tests.csproj]
D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Instrumentation.Hangfire\HangfireInstrumentationOptions.cs(40,89): error SA1629: Documentation text should end with a period [D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Instrumentation.Hangfire\OpenTelemetry.Instrumentation.Hangfire.csproj]

[prochnowc]

^ That is only a warning and not an error. Build fails for different reason.

Oh, sorry - did not see the actual error because of the irritating warning. It's fixed now.

The remaining problem seems to be a test failure in a project I did not touch:
Failed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully