Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Migrate shared code tests from main repository #1806

Merged
merged 3 commits into from
May 16, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 16, 2024

Follow up to open-telemetry/opentelemetry-dotnet#5599 (comment)

Changes

Migrate shared code tests from main repository

https://github.com/open-telemetry/opentelemetry-dotnet/tree/1bbafaa7b7bed6470ff52fc76b6e881cd19692a5
Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team May 16, 2024 05:57
@Kielek Kielek added the infra Infra work - CI/CD, code coverage, linters label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.98%. Comparing base (71655ce) to head (a76ab3d).
Report is 246 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
+ Coverage   73.91%   74.98%   +1.06%     
==========================================
  Files         267      297      +30     
  Lines        9615    10968    +1353     
==========================================
+ Hits         7107     8224    +1117     
- Misses       2508     2744     +236     
Flag Coverage Δ
unittests-Exporter.Geneva 61.63% <ø> (?)
unittests-Exporter.OneCollector 89.46% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 74.54% <ø> (?)
unittests-Instrumentation.GrpcNetClient 78.78% <ø> (?)
unittests-Instrumentation.Http 81.08% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 82.03% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 93.33% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Solution 79.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 285 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title Migrate shared code tests from main repository [repo] Migrate shared code tests from main repository May 16, 2024
@CodeBlanch CodeBlanch merged commit c7dc6ae into open-telemetry:main May 16, 2024
160 checks passed
@Kielek Kielek deleted the migrate-shared-code branch May 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants