-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Migrate shared code tests from main repository #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 73.91% 74.98% +1.06%
==========================================
Files 267 297 +30
Lines 9615 10968 +1353
==========================================
+ Hits 7107 8224 +1117
- Misses 2508 2744 +236
Flags with carried forward coverage won't be shown. Click here to find out more. |
2 tasks
rajkumar-rangaraj
approved these changes
May 16, 2024
CodeBlanch
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vishweshbankwar
approved these changes
May 16, 2024
CodeBlanch
changed the title
Migrate shared code tests from main repository
[repo] Migrate shared code tests from main repository
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to open-telemetry/opentelemetry-dotnet#5599 (comment)
Changes
Migrate shared code tests from main repository
https://github.com/open-telemetry/opentelemetry-dotnet/tree/1bbafaa7b7bed6470ff52fc76b6e881cd19692a5
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed