Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Http] Move package from main repository #1694

Merged
merged 33 commits into from
Apr 26, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 25, 2024

Towards open-telemetry/opentelemetry-dotnet#5526

Leftover: #1693

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek added the comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http label Apr 25, 2024
@Kielek Kielek requested a review from a team April 25, 2024 11:52
@Kielek Kielek force-pushed the migrate-http-instrumentation branch from d6e3eac to a1070f2 Compare April 25, 2024 11:55
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 82.01183% with 152 lines in your changes are missing coverage. Please review.

Project coverage is 75.25%. Comparing base (71655ce) to head (ff96e3f).
Report is 221 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
+ Coverage   73.91%   75.25%   +1.33%     
==========================================
  Files         267      281      +14     
  Lines        9615    10975    +1360     
==========================================
+ Hits         7107     8259    +1152     
- Misses       2508     2716     +208     
Flag Coverage Δ
unittests-Exporter.Geneva 63.03% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.39% <100.00%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Http 81.90% <81.90%> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 79.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AspNet/Implementation/HttpInListener.cs 88.46% <100.00%> (+0.14%) ⬆️
...ion.AspNet/Implementation/HttpInMetricsListener.cs 97.36% <100.00%> (-2.64%) ⬇️
...pNet/Implementation/RequestDataHelperExtensions.cs 100.00% <100.00%> (ø)
....Instrumentation.Http/HttpClientInstrumentation.cs 100.00% <100.00%> (ø)
...ntInstrumentationMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tInstrumentationTracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...elemetry.Instrumentation.Http/HttpClientMetrics.cs 100.00% <100.00%> (ø)
...tion.Http/HttpClientTraceInstrumentationOptions.cs 100.00% <100.00%> (ø)
...ation.Http/HttpRequestMessageContextPropagation.cs 100.00% <100.00%> (ø)
...strumentation.Http/Implementation/HttpTagHelper.cs 100.00% <100.00%> (ø)
... and 5 more

... and 230 files with indirect coverage changes

@Kielek Kielek marked this pull request as draft April 25, 2024 12:17
@Kielek Kielek force-pushed the migrate-http-instrumentation branch from b91640f to d820e07 Compare April 26, 2024 04:57
@Kielek Kielek marked this pull request as ready for review April 26, 2024 05:11
# Changelog

* Update `OpenTelemetry.Api.ProviderBuilderExtensions` to `1.8.1`.
* Update `OpenTelemetry.Api` to `1.8.1`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to mention OpenTelemetry.Api separately. We only target OpenTelemetry.Api.ProviderBuilderExtensions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is transitive dependency. Entry is copied from SqlClient, before I copied it from another package referencing exactly this package.

We can fix it all at once in separate PR if you want.

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left couple minor comments.

@Kielek Kielek merged commit 59b5c3b into open-telemetry:main Apr 26, 2024
133 of 134 checks passed
@Kielek Kielek deleted the migrate-http-instrumentation branch April 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants