-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Http] Move package from main repository #1694
[Instrumentation.Http] Move package from main repository #1694
Conversation
d6e3eac
to
a1070f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
+ Coverage 73.91% 75.25% +1.33%
==========================================
Files 267 281 +14
Lines 9615 10975 +1360
==========================================
+ Hits 7107 8259 +1152
- Misses 2508 2716 +208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
to avoid concurency and random tests failure.
b91640f
to
d820e07
Compare
# Changelog | ||
|
||
* Update `OpenTelemetry.Api.ProviderBuilderExtensions` to `1.8.1`. | ||
* Update `OpenTelemetry.Api` to `1.8.1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to mention OpenTelemetry.Api
separately. We only target OpenTelemetry.Api.ProviderBuilderExtensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is transitive dependency. Entry is copied from SqlClient, before I copied it from another package referencing exactly this package.
We can fix it all at once in separate PR if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left couple minor comments.
Towards open-telemetry/opentelemetry-dotnet#5526
Leftover: #1693
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes