Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet] fix metric description #1063

Merged
merged 1 commit into from
Mar 4, 2023
Merged

[Instrumentation.AspNet] fix metric description #1063

merged 1 commit into from
Mar 4, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Mar 4, 2023

Fixes #4169
Is a continuation of #4171
Initiated by this issue on the OpenTelemetry Demo

Changes

Fixes the metric description to conform with specifications and prevent errors from the Prometheus exporter in the collector.

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1063 (a5de5aa) into main (6dc0417) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files         203      203           
  Lines        7783     7783           
=======================================
  Hits         5439     5439           
  Misses       2344     2344           
Impacted Files Coverage Δ
...xporter.Instana/TracerProviderBuilderExtensions.cs 0.00% <ø> (ø)
...ion.AspNet/Implementation/HttpInMetricsListener.cs 100.00% <100.00%> (ø)

@cijothomas cijothomas merged commit 4485a1c into open-telemetry:main Mar 4, 2023
@puckpuck puckpuck deleted the fix_metric_description branch March 4, 2023 21:29
@utpilla utpilla added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Mar 5, 2023
@cartersocha
Copy link

Hey @utpilla could we get this fix released or is there a release timeline? We'd like to close a bug in the demo and it's blocked on this

@cartersocha
Copy link

Or @cijothomas ?

@cijothomas
Copy link
Member

Releases from contrib repo are based on explicit asks only.
Please use this to request a release:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Server Duration Histogram description does not follow specification
4 participants