Add Windows instructions for gradle #80
Conversation
|
|
||
| ```shell | ||
| cd src/adservice/ | ||
| ./gradlew installDist |
There was a problem hiding this comment.
| ./gradlew installDist | |
| .\gradlew installDist |
|
A general question before looking at the actual PR changes: do we intend to have any platform specific instructions in this repo or not? IMHO the answer is no (it should be platform agnostic, all the details are supposed to be smoothed out by containerization). |
| @@ -28,6 +28,16 @@ git clone https://github.com/open-telemetry/opentelemetry-demo-webstore.git | |||
| cd opentelemetry-demo-webstore/ | |||
| ``` | |||
|
|
|||
| ### Gradle Update [Windows Only] | |||
There was a problem hiding this comment.
What's the common practice in Java?
It seems currently a hard copy is saved in the repo (which is surprising to me) https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/77bd1495546b8105efb18a682d564b48acca35ee/src/adservice/gradle/wrapper/gradle-wrapper.jar.
There was a problem hiding this comment.
Not sure, I'll look more into it and also just asked on the slack
There was a problem hiding this comment.
Its normal and idiomatic to check the gradlew and corresponding jar file into git.
|
In favour of this PR from my fork #81 (Git wouldn't let me make further changes to this branch) |
Towards #77
Changes
README.md