-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete client programs #308
Conversation
Uh, I'd expect other services to be using those clients... did the frontend use them before being refactored? |
The other services create their own clients from the protocol buffer definition file. |
I'm all for removing the clients from this. They are meant to be used if you are locally developing just a specific service. This is a project to showcase OpenTelemetry data flowing through multiple services. I think the clients will cause unnecessary confusion, and removing them helps avoid that confusion. |
Converting to draft, have to remove clients from gradle and cmake |
Adding @DebajitDas @lalitb who originally introduced the C++ client file and reviewed the PR #189. I think the clients were used by the developers who have quick local test (whether it's functionality or perf or stress). Maybe these developers would find it helpful to keep the files somewhere (e.g. under a test folder)? |
Yes. client code is handy for quick local tests, it would be good to have it in test directory, if it is causing any confusion. |
* Delete client programs * duplicate item to cart test * gradle and cmake cleanup * undo test change oops Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Deletes clients to the services
currencyservice
andadservice
.The functionality of these programs is covered by
/test/test.js
client.cpp
to/test/test.js
I'm interested in if people have opinions on this removal or if this repository should provide any instructions or examples on how to write a gRPC client or is the focus more-so on the services.