Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webstore demo metric enhancement #175

Merged
merged 6 commits into from
Jun 29, 2022

Conversation

fatsheep9146
Copy link
Contributor

Changes

Following #160, I try to enhance the metrics feature for webstore in several ways:

  • Scrape the metrics for collector itself
  • Add grafana service with following features
    • without need to login
    • start with prometheus service as datasource
    • start with several out of box dashboards stored in path src/grafana/provisioning/dashboards, I first add a official dashboard for opentelemetry-collector, more dashboards can be added in this folder for example the dashboard for frontend service.

For now, this pr is not good enough, I really hope listen to your advises. :-)

Here are some screen shot for grafana, which can be visited in http//:127.0.0.1:3000

Grafana homepage, open without need to login
image

Prometheus service as datasource, whose name is webstore
image

Opentelemetry-collector dashboard
image

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146 fatsheep9146 requested a review from a team June 28, 2022 14:28
@fatsheep9146 fatsheep9146 changed the title Demo metric enhancement webstore demo metric enhancement Jun 28, 2022
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

.env Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@mic-max
Copy link
Contributor

mic-max commented Jun 28, 2022

Could you add a similar to this PR link to the grafana endpoint

cartersocha and others added 2 commits June 28, 2022 12:42
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146
Copy link
Contributor Author

Could you add a similar to this PR link to the grafana endpoint

Absolutely, done.

@cartersocha cartersocha merged commit f8db21d into open-telemetry:main Jun 29, 2022
@cartersocha
Copy link
Contributor

cartersocha commented Jun 29, 2022

Thanks for maturing the metrics support @fatsheep9146!

GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* add basic usage of grafana

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* add more config for grafana

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for yamllint

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for yamllint

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for reviews

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add basic usage of grafana

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* add more config for grafana

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for yamllint

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for yamllint

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

* fix for reviews

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants