Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: remove integration tests #1406

Merged
merged 4 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/build-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,6 @@ jobs:
tag_suffix: frontend-tests
context: ./
setup-qemu: true
- file: ./test/Dockerfile
tag_suffix: integrationTests
context: ./
setup-qemu: true

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ the release.
([#1397](https://github.com/open-telemetry/opentelemetry-demo/pull/1397))
* [chore] add nightly releases
([#1398](https://github.com/open-telemetry/opentelemetry-demo/pull/1398))
* [chore] remove unused integration test
([#1406](https://github.com/open-telemetry/opentelemetry-demo/pull/1406))

## 1.8.0

Expand Down
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ build-env-file:
.PHONY: run-tests
run-tests:
docker compose run frontendTests
# integrationTests is deprecated in favor of traceBasedTests
# docker compose run integrationTests
docker compose run traceBasedTests

.PHONY: run-tracetesting
Expand Down
31 changes: 0 additions & 31 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -750,37 +750,6 @@ services:
depends_on:
- frontend

# Integration Tests
integrationTests:
image: ${IMAGE_NAME}:${DEMO_VERSION}-integrationTests
container_name: integrationTests
profiles:
- tests
build:
context: ./
dockerfile: ./test/Dockerfile
environment:
- AD_SERVICE_ADDR
- CART_SERVICE_ADDR
- CHECKOUT_SERVICE_ADDR
- CURRENCY_SERVICE_ADDR
- EMAIL_SERVICE_ADDR
- PAYMENT_SERVICE_ADDR
- PRODUCT_CATALOG_SERVICE_ADDR
- RECOMMENDATION_SERVICE_ADDR
- SHIPPING_SERVICE_ADDR
depends_on:
- adservice
- cartservice
- checkoutservice
- currencyservice
- emailservice
- paymentservice
- productcatalogservice
- recommendationservice
- shippingservice
- quoteservice

# Tracebased Tests
traceBasedTests:
image: ${IMAGE_NAME}:${DEMO_VERSION}-traceBasedTests
Expand Down
26 changes: 0 additions & 26 deletions test/Dockerfile

This file was deleted.

24 changes: 4 additions & 20 deletions test/README.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,10 @@
# Service Testing

There are two ways to test the service APIs in the OpenTelemetry Demo:
The OpenTelemetry Demo uses traced-based testing to validate the
functionality of the services and the traces they generate.

1. Using black box-testing, calling gRPC services
and validating their direct response
2. Using Trace-based tests, calling both HTTP and
gRPC services and validating their direct response as well as
the distributed traces they generate

## Testing gRPC services as black boxes

To run the entire test suite as a black box, run the command:

```sh
docker compose run integrationTests
```

If you want to run tests for a specific service, run:

1. Start the services you want to test with `docker compose up --build <service>`
2. Run `npm install`
3. Run `npm test` or `npx ava --match='<pattern>'` to match test names
The trace-based tests will each service and validate the traces they
generate and stored in Jaeger, to a known working trace for the same operation.

## Testing services with Trace-based tests

Expand Down
102 changes: 0 additions & 102 deletions test/data.json

This file was deleted.

Loading
Loading