[chore]: remove integration tests (#1406)

* yeet integration tests Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * yeet integration tests Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * yeet integration tests Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io>
open-telemetry · Feb 22, 2024 · ef31bfd · ef31bfd
1 parent 6bd2ede
commit ef31bfd
Show file tree

Hide file tree

Showing 10 changed files with 6 additions and 3,425 deletions.
diff --git a/.github/workflows/build-images.yml b/.github/workflows/build-images.yml
@@ -115,10 +115,6 @@ jobs:
             tag_suffix: frontend-tests
             context: ./
             setup-qemu: true
-          - file: ./test/Dockerfile
-            tag_suffix: integrationTests
-            context: ./
-            setup-qemu: true
 
     steps:
       - uses: actions/checkout@v4

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@ the release.
   ([#1397](https://github.com/open-telemetry/opentelemetry-demo/pull/1397))
 * [chore] add nightly releases
   ([#1398](https://github.com/open-telemetry/opentelemetry-demo/pull/1398))
+* [chore] remove unused integration test
+  ([#1406](https://github.com/open-telemetry/opentelemetry-demo/pull/1406))
 
 ## 1.8.0
 

diff --git a/Makefile b/Makefile
@@ -98,8 +98,6 @@ build-env-file:
 .PHONY: run-tests
 run-tests:
 	docker compose run frontendTests
-	# integrationTests is deprecated in favor of traceBasedTests
-	# docker compose run integrationTests
 	docker compose run traceBasedTests
 
 .PHONY: run-tracetesting

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -750,37 +750,6 @@ services:
     depends_on:
       - frontend
 
-  # Integration Tests
-  integrationTests:
-    image: ${IMAGE_NAME}:${DEMO_VERSION}-integrationTests
-    container_name: integrationTests
-    profiles:
-      - tests
-    build:
-      context: ./
-      dockerfile: ./test/Dockerfile
-    environment:
-      - AD_SERVICE_ADDR
-      - CART_SERVICE_ADDR
-      - CHECKOUT_SERVICE_ADDR
-      - CURRENCY_SERVICE_ADDR
-      - EMAIL_SERVICE_ADDR
-      - PAYMENT_SERVICE_ADDR
-      - PRODUCT_CATALOG_SERVICE_ADDR
-      - RECOMMENDATION_SERVICE_ADDR
-      - SHIPPING_SERVICE_ADDR
-    depends_on:
-      - adservice
-      - cartservice
-      - checkoutservice
-      - currencyservice
-      - emailservice
-      - paymentservice
-      - productcatalogservice
-      - recommendationservice
-      - shippingservice
-      - quoteservice
-
   # Tracebased Tests
   traceBasedTests:
     image: ${IMAGE_NAME}:${DEMO_VERSION}-traceBasedTests

diff --git a/test/Dockerfile b/test/Dockerfile
diff --git a/test/README.md b/test/README.md
@@ -1,26 +1,10 @@
 # Service Testing
 
-There are two ways to test the service APIs in the OpenTelemetry Demo:
+The OpenTelemetry Demo uses traced-based testing to validate the
+functionality of the services and the traces they generate.
 
-1. Using black box-testing, calling gRPC services
-and validating their direct response
-2. Using Trace-based tests, calling both HTTP and
-gRPC services and validating their direct response as well as
-the distributed traces they generate
-
-## Testing gRPC services as black boxes
-
-To run the entire test suite as a black box, run the command:
-
-```sh
-docker compose run integrationTests
-```
-
-If you want to run tests for a specific service, run:
-
-1. Start the services you want to test with `docker compose up --build <service>`
-2. Run `npm install`
-3. Run `npm test` or `npx ava --match='<pattern>'` to match test names
+The trace-based tests will each service and validate the traces they
+generate and stored in Jaeger, to a known working trace for the same operation.
 
 ## Testing services with Trace-based tests
 

diff --git a/test/data.json b/test/data.json