Move env-var read logic to common dir, and optional reading of env-var #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #924 +/- ##
==========================================
+ Coverage 95.36% 95.36% +0.01%
==========================================
Files 159 160 +1
Lines 6775 6779 +4
==========================================
+ Hits 6460 6464 +4
Misses 315 315
|
ThomsonTan
reviewed
Jul 30, 2021
| { | ||
| constexpr char kOtlpGrpcIsSslEnableEnv[] = "OTEL_EXPORTER_OTLP_GRPC_SSL_ENABLE"; | ||
| auto ssl_enable = opentelemetry::sdk::common::GetEnvironmentVariable(kOtlpGrpcIsSslEnableEnv); | ||
| if (ssl_enable == "True" || ssl_enable == "TRUE" || ssl_enable == "true" || ssl_enable == "1") |
There was a problem hiding this comment.
Convert it to lower case before comparison, to make the comparison case insensitive?
There was a problem hiding this comment.
Good point will change that.
There was a problem hiding this comment.
Ok. I realize there is no method available in stdlib to perform this conversion. we have to iterate over the string to convert it. The existing comparison looks simple as compared to that :)
ThomsonTan
approved these changes
Jul 30, 2021
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes