Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix zipkin exporter compile failure #899

Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Jul 11, 2021

Fixes # (issue)

Changes

The following method is marked override but it doesn't override:
exporter::zipkin::Recordable::SetStatus(trace::StatusCode code, nostd::string_view description) noexcept override;

compile error:

In file included from <path>/include/opentelemetry/exporters/zipkin/zipkin_exporter.h:6,
                 from /opt/otel/main.cc:11:
<path>/include/opentelemetry/exporters/zipkin/recordable.h:43:25: error: 'opentelemetry::v0::exporter::trace::StatusCode' has not been declared
   43 |   void SetStatus(trace::StatusCode code, nostd::string_view description) noexcept override;
      |                         ^~~~~~~~~~
<path>/include/opentelemetry/exporters/zipkin/recordable.h:43:8: error: 'void opentelemetry::v0::exporter::zipkin::Recordable::SetStatus(int, opentelemetry::v0::nostd::string_view)' marked 'override', but does not override
   43 |   void SetStatus(trace::StatusCode code, nostd::string_view description) noexcept override;
      |        ^~~~~~~~~
make[2]: *** [CMakeFiles/simpleOtel.dir/build.make:63: CMakeFiles/simpleOtel.dir/main.cc.o] Error 1
make[2]: Leaving directory '/opt/otel/build'

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team July 11, 2021 14:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Will merge once formatting is fixed.

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #899 (a97927c) into main (2209343) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         158      158           
  Lines        6717     6717           
=======================================
  Hits         6408     6408           
  Misses        309      309           

@esigo
Copy link
Member Author

esigo commented Jul 11, 2021

Thanks for the fix. Will merge once formatting is fixed.

Thanks for the review.
I fixed the format using tools/format.sh.

@lalitb lalitb merged commit be32bde into open-telemetry:main Jul 11, 2021
@esigo esigo deleted the esigo/zipkin-exporter-compile-failure branch November 1, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants