reporing instumentation library as tags in jaeger span #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 156 156
Lines 6620 6620
=======================================
Hits 6322 6322
Misses 298 298 |
lalitb
approved these changes
Jun 16, 2021
ThomsonTan
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768
Changes
Adding instrumentation library (name and version) in jaeger span as tags using thrift add tags.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes