Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OtlpHttpExporter to support timeout and cancle #853

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

owent
Copy link
Member

@owent owent commented Jun 14, 2021

Signed-off-by: owent admin@owent.net

Fixes #852

Changes

Use HttpClient to replace HttpClientSync .

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Signed-off-by: owent <admin@owent.net>
@owent owent requested a review from a team June 14, 2021 07:06
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #853 (1ea9503) into main (521ebd8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   95.48%   95.49%   +0.01%     
==========================================
  Files         156      156              
  Lines        6615     6617       +2     
==========================================
+ Hits         6316     6318       +2     
  Misses        299      299              
Impacted Files Coverage Δ
...include/opentelemetry/ext/http/common/url_parser.h 91.49% <100.00%> (+0.38%) ⬆️

Signed-off-by: owent <admin@owent.net>
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lalitb
Copy link
Member

lalitb commented Jun 14, 2021

@open-telemetry/cpp-approvers - I will take the liberty to merge it, as this was a fix for earlier reverted changes from PR #803.

@lalitb lalitb merged commit fa2caa8 into open-telemetry:main Jun 14, 2021
@@ -65,6 +68,7 @@ struct OtlpHttpExporterOptions

// TODO: Enable/disable to verify SSL certificate
// TODO: Reuqest timeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO could be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This PR is already merged, maybe it can be remove in another PR later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if I merged it a bit earlier. There is a task to remove/handle invalid TODOs from the code base, this can be handled through that if not done before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement timeout and cancelable OtlpHttpExporter
3 participants