Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements for ETW exporter #519

Merged
merged 94 commits into from
Apr 3, 2021
Merged

Code improvements for ETW exporter #519

merged 94 commits into from
Apr 3, 2021

Commits on Jan 12, 2021

  1. Drafts for proper TLD operation. Verified that TLD flow works well wi… 

    …th existing ETW tooling.
    @maxgolov
    maxgolov committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6bd4aaa View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Add CODEOWNERS for ETW exporter

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f8a3af1 View commit details
    Browse the repository at this point in the history

  2. Add support for owning Properties container

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    035d863 View commit details
    Browse the repository at this point in the history

  3. Make SpanContextKeyValueIterable empty container by default

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    1141e29 View commit details
    Browse the repository at this point in the history

  4. is_key_value_iterable does not property test for subclasses of KeyVal… 

    …ueIterable: relax this restriction for now
    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    01cd9ac View commit details
    Browse the repository at this point in the history

  5. Allow C string type

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    01c693c View commit details
    Browse the repository at this point in the history

  6. Add ability for vendors to customize their ETW field names

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    66b1ee2 View commit details
    Browse the repository at this point in the history

  7. Code refactor to address outstanding feature parity issues

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    90ecfd0 View commit details
    Browse the repository at this point in the history

  8. Code formatting

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    5acc2d3 View commit details
    Browse the repository at this point in the history

  9. Fix glob for Bazel build

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    013d1fd View commit details
    Browse the repository at this point in the history

  10. Fix Bazel formatting issue

    @maxgolov
    maxgolov committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    956e38d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into maxgolov/etw_exporter

    @maxgolov
    maxgolov authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    bcc54f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Wrong #ifdef in test

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    846ad71 View commit details
    Browse the repository at this point in the history

  2. Add prometheus to Visual Studio 2019 CMake build configuration

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    16ccb2a View commit details
    Browse the repository at this point in the history

  3. Add support for span<uint8_t> and const char * to OTLP exporter

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    fc55f3c View commit details
    Browse the repository at this point in the history

  4. Sort OwnedAttributeValue in the same order as AttributeValue (for con… 

    …sistency), plus add converter from const char *
    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    1b039a8 View commit details
    Browse the repository at this point in the history

  5. Use enums instead of hardcoded constants

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    af1718f View commit details
    Browse the repository at this point in the history

  6. Add prometheus-cpp to vcpkg build on Windows

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    d142031 View commit details
    Browse the repository at this point in the history

  7. include(CTest) and only then if(BUILD_TESTING)

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    c02a822 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'maxgolov/etw_exporter' of https://github.com/open-telem… 

    …etry/opentelemetry-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    d86267f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of https://github.com/open-telemetry/openteleme… 

    …try-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    c4d73ad View commit details
    Browse the repository at this point in the history

  10. Fix CI failures

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    afd035e View commit details
    Browse the repository at this point in the history

  11. Add nlohmann/json to CMake build

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    a1141e4 View commit details
    Browse the repository at this point in the history

  12. Compile empty stub for writeMsgPack when HAVE_MSGPACK is not defined

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    93b2480 View commit details
    Browse the repository at this point in the history

  13. Build Bazel with ETW-MsgPack exporter

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    897da33 View commit details
    Browse the repository at this point in the history

  14. Add nlohmann_json to bazel build of ETW exporter

    @maxgolov
    maxgolov committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    07952be View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Merge branch 'master' of https://github.com/open-telemetry/openteleme… 

    …try-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    09d8fa9 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Incremental clean-up and simplify Bazel build

    @maxgolov
    maxgolov committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    8a737c7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into maxgolov/etw_exporter

    @maxgolov
    maxgolov authored Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a4b459d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Update .github/CODEOWNERS 

    Co-authored-by: Johannes Tax <johannestax@microsoft.com>
    @maxgolov @pyohannes
    maxgolov and pyohannes authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0c3b167 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Merge branch 'master' into maxgolov/etw_exporter

    @maxgolov
    maxgolov authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    fc2cbb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Allow populating Span from byte buffer

    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    b7153eb View commit details
    Browse the repository at this point in the history

  2. Allow populating TraceId from byte buffer

    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    a09a941 View commit details
    Browse the repository at this point in the history

  3. Allow populating ActivityId and RelatedActivity based on SpanId and P… 

    …arentSpanId
    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    5de423b View commit details
    Browse the repository at this point in the history

  4. Automated context propagation

    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    4b5d3b7 View commit details
    Browse the repository at this point in the history

  5. Include headers for CoCreateGuid

    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    fdda4da View commit details
    Browse the repository at this point in the history

  6. Added 3-level deep spans to test

    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    ee14876 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter_ActivityId
    @maxgolov
    maxgolov committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    51461d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter_ActivityId
    @maxgolov
    maxgolov committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    ebcd88e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter_ActivityId
    @maxgolov
    maxgolov committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    c81d08e View commit details
    Browse the repository at this point in the history

  3. Reformat code

    @maxgolov
    maxgolov committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    44f0ce2 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter_ActivityId
    @maxgolov
    maxgolov committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    c3a7442 View commit details
    Browse the repository at this point in the history

  2. Build Release without debug info

    @maxgolov
    maxgolov committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    6d70f6d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter_ActivityId
    @maxgolov
    maxgolov committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    81f0db9 View commit details
    Browse the repository at this point in the history

  2. Rename test provider to OpenTelemetry-ETW-Provider

    @maxgolov
    maxgolov committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    9475c16 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'maxgolov/etw_exporter_ActivityId' of https://github.com… 

    …/open-telemetry/opentelemetry-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0d993d0 View commit details
    Browse the repository at this point in the history

  4. Reformat code using latest formatter

    @maxgolov
    maxgolov committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e159b2c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4adafce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. define HAVE_TLD only if it hasn't been defined yet

    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    c9f1efa View commit details
    Browse the repository at this point in the history

  2. Fix C++17 issue regarding deprecated C++11 codecvt

    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    ec0ef2e View commit details
    Browse the repository at this point in the history

  3. Add tests for detailed decorator and min decorator

    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    48adeea View commit details
    Browse the repository at this point in the history

  4. Add smarter ref-counting logic to ETW provider, allowing multiple tra… 

    …cers to reuse the same provider more efficiently
    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    c3d0dc8 View commit details
    Browse the repository at this point in the history

  5. ETW Tracer improvements: 

    - configuration API surface for ETW TracerProvider
- OPTIONAL support for native ETW correlation techniques (ActivityId, RelatedActivityId)
- OPTIONAL support for min-size vs detailed events (stamping TraceId, SpanId, SpanParentId)
    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    753521b View commit details
    Browse the repository at this point in the history

  6. Code formatting changes

    @maxgolov
    maxgolov committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    5ed213c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Add time routines to utils

    @maxgolov
    maxgolov committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    1d46f76 View commit details
    Browse the repository at this point in the history

  2. Fix bug in format passing

    @maxgolov
    maxgolov committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    131f801 View commit details
    Browse the repository at this point in the history

  3. Add separate tests for TLD (TraceLoggingDynamic) encoding and MsgPack… 

    … encoding
    @maxgolov
    maxgolov committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    51bea36 View commit details
    Browse the repository at this point in the history

  4. Clean-up field names for ETW notation (common field names used for bo… 

    …th ETW/TLD and ETW/MsgPack)
    @maxgolov
    maxgolov committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    4543a47 View commit details
    Browse the repository at this point in the history

  5. ETW/MsgPack: Chunk Span Start, Span Event, Span Stop as individual ET… 

    …W events instead of consolidating in a single tree.

This is much more appropriate for heavily multi-threaded C++ apps, and provides predictable flow that may be subsequently
reconstructed / consolidated into a single tree of spans by out-of-proc listener agent, e.g. by Azure Diagnostics EventFlow.
    @maxgolov
    maxgolov committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    48991c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8678a91 View commit details
    Browse the repository at this point in the history

  2. Fix GMock linkage error on Windows 

    Fix GMock linkage error on Windows.
    @maxgolov
    maxgolov authored Mar 26, 2021
    Configuration menu
    Copy the full SHA
    665422e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'maxgolov/cmake_windows_fix' of https://github.com/open-… 

    …telemetry/opentelemetry-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    fb71a95 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Addressing code review comments

    @maxgolov
    maxgolov committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    f459bd3 View commit details
    Browse the repository at this point in the history

  2. Remove unused templates

    @maxgolov
    maxgolov committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    4fd5528 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Add benchmark to compare Properties vs initializer list vs unordered_… 

    …map events
    @maxgolov
    maxgolov committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    da56e3e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2951a1e View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Update exporters/etw/include/opentelemetry/exporters/etw/etw_provider.h 

    Co-authored-by: Tom Tan <Tom.Tan@microsoft.com>
    @maxgolov @ThomsonTan
    maxgolov and ThomsonTan authored Mar 31, 2021
    Configuration menu
    Copy the full SHA
    127f149 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    b51040a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'main' of https://github.com/open-telemetry/opentelemetr… 

    …y-cpp into maxgolov/etw_exporter
    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    0f2b8d6 View commit details
    Browse the repository at this point in the history

  2. Revert "Find GTest via CONFIG mode to reference gmock (#640)" 

    This reverts commit 3ddda3c.
    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    b78797f View commit details
    Browse the repository at this point in the history

  3. Add time formatting utility

    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    a683ed5 View commit details
    Browse the repository at this point in the history

  4. Rename 'kind' field to 'OpCode' (start or stop)

    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    1db003e View commit details
    Browse the repository at this point in the history

  5. Tests are no longer included in Windows build

    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    3a7831a View commit details
    Browse the repository at this point in the history

  6. New feature to consolidate all Span info on end of Span into separate… 

    … `Span` event
    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    b0c31bf View commit details
    Browse the repository at this point in the history

  7. Apply code formatting rules

    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    bcf7325 View commit details
    Browse the repository at this point in the history

  8. Add support for const char* and byte arrays under feature gate in Zip… 

    …kin exporter
    @maxgolov
    maxgolov committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    1561bd0 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Rename type to Google coding style kTypeString

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    b51cd39 View commit details
    Browse the repository at this point in the history

  2. Addressing code review comments: remove api change

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    61b2f7c View commit details
    Browse the repository at this point in the history

  3. Addressing code review comments: rename namespace from ETW to etw

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    467f823 View commit details
    Browse the repository at this point in the history

  4. Remove ETW recordable class as it is not needed

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    576d510 View commit details
    Browse the repository at this point in the history

  5. Remove HAVE_CSTRING_TYPE build option

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    a1653b4 View commit details
    Browse the repository at this point in the history

  6. Remove API changes

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    57ab55b View commit details
    Browse the repository at this point in the history

  7. Rename namespace from ETW to etw

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    1b0baf7 View commit details
    Browse the repository at this point in the history

  8. Rename namespace from ETW to etw

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    e37cee5 View commit details
    Browse the repository at this point in the history

  9. Address code review comment: rename enum types to follow Google codin… 

    …g style
    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    63f793d View commit details
    Browse the repository at this point in the history

  10. Remove HAVE_CSTRING_TYPE

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    a8afc39 View commit details
    Browse the repository at this point in the history

  11. Rename enum types to follow Google coding style

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    18b2f9b View commit details
    Browse the repository at this point in the history

  12. Remove HAVE_CSTRING_TYPE build option

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    c2777e2 View commit details
    Browse the repository at this point in the history

  13. Remove HAVE_CSTRING_TYPE option and rename enums to follow Google Cod… 

    …ing style
    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    bf8a3d4 View commit details
    Browse the repository at this point in the history

  14. Rename namespace from ETW to etw

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    8feee53 View commit details
    Browse the repository at this point in the history

  15. Rename types to match Google coding style

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    888a040 View commit details
    Browse the repository at this point in the history

  16. Fix mismatched ifdef

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    69c5e66 View commit details
    Browse the repository at this point in the history

  17. Revert changes to TraceZ

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    80512b5 View commit details
    Browse the repository at this point in the history

  18. true should be returned from Null object pattern to indicate success

    @maxgolov
    maxgolov committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    550f2d8 View commit details
    Browse the repository at this point in the history