-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zPages usage instructions, remove unneeded details #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jajanet
commented
Aug 20, 2020
•
edited
Loading
edited
- Add usage instructions for Bazel, including how to run the example
- Add TODO for making CMake instructions
- Remove most of the zPages explanation, replacing it with a link to the zPages spec
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 93.93% 94.43% +0.49%
==========================================
Files 146 146
Lines 6564 6596 +32
==========================================
+ Hits 6166 6229 +63
+ Misses 398 367 -31
|
Closed
jajanet
added a commit
to kmanghat/opentelemetry-cpp
that referenced
this pull request
Aug 22, 2020
reyang
reviewed
Aug 24, 2020
reyang
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.