Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove the incorrect set of CMAKE_MSVC_RUNTIME_LIBRARY for vcpkg #2696

Merged

Conversation

ThomsonTan
Copy link
Contributor

Changes

VCPKG_LIBRARY_LINKAGE should only be visible to triplet file, not he cmake file using vcpkg as toolchain. So the setting of CMAKE_MSVC_RUNTIME_LIBRARY is incorrect with VCPKG_LIBRARY_LINKAGE referenced in the generator expression. It will always be "" (empty) instead of the expected "static" or "dynamic".

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 6, 2024 05:35
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (3778e3f).
Report is 75 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 74 files with indirect coverage changes

@ThomsonTan ThomsonTan merged commit 1d8a7b5 into open-telemetry:main Jun 6, 2024
50 checks passed
@ThomsonTan ThomsonTan deleted the remove_msvc_runtime_library_vcpkg branch June 6, 2024 16:24
@ThomsonTan
Copy link
Contributor Author

@owent FYI. Feel free to let me know if anything is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants