Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Do not link prometheus-cpp::util when it doesn't exist #2606

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[BUILD] Do not link prometheus-cpp::util when it doesn't exist #2606

merged 1 commit into from
Mar 25, 2024

Conversation

owent
Copy link
Member

@owent owent commented Mar 25, 2024

Fixes #2605

Changes

  • Do not link prometheus-cpp::util when it doesn't exist

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team March 25, 2024 06:34
marcalff
marcalff approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@marcalff marcalff merged commit 02e6ad2 into open-telemetry:main Mar 25, 2024
47 checks passed
@marcalff marcalff changed the title Do not link prometheus-cpp::util when it doesn't exist [BUILD] Do not link prometheus-cpp::util when it doesn't exist Mar 25, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
@owent owent deleted the fixes_2605 branch June 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prometheus-cpp::util is not found in prometheus-cpp 1.1.0 and before. Which will make prometheus fail to build
2 participants
@owent @marcalff