Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to prometheus 1.2.4 #2598

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Upgrade to prometheus 1.2.4 #2598

merged 6 commits into from
Mar 22, 2024

Conversation

marcalff
Copy link
Member

Upgrade to prometheus 1.2.4

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team March 21, 2024 15:15
@marcalff
Copy link
Member Author

marcalff commented Mar 21, 2024 •
edited
Loading

CMake failure related to:

commit bd8029332829beb795f73558c070404aba6a5ffc
Author: Gregor Jasny gjasny@googlemail.com
Date: Mon Dec 18 08:46:23 2023 +0100

chore: move base64 implementation into internal utility library

jupp0r/prometheus-cpp#672

@ThomsonTan ThomsonTan merged commit f2f0738 into open-telemetry:main Mar 22, 2024
47 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
@marcalff marcalff deleted the fix_upgrade_prometheus branch June 3, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalff @ThomsonTan @lalitb