Change OTLP HTTP content_type default to binary #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
approved these changes
Feb 27, 2024
esigo
approved these changes
Feb 27, 2024
Comment on lines
+18
to
+21
| else | ||
| { | ||
| return HttpRequestContentType::kBinary; | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| else | |
| { | |
| return HttpRequestContentType::kBinary; | |
| } | |
| return HttpRequestContentType::kBinary; |
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Feb 27, 2024
Change OTLP HTTP content_type default to binary (open-telemetry#2558)
lalitb
added a commit
that referenced
this pull request
Feb 27, 2024
ThomsonTan
added a commit
to ThomsonTan/opentelemetry-cpp
that referenced
this pull request
Feb 27, 2024
…try#2558)" (open-telemetry#2562) This reverts commit 719c60f.
ThomsonTan
added a commit
that referenced
this pull request
Feb 27, 2024
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Feb 28, 2024
Reapply "Change OTLP HTTP content_type default to binary (open-telemetry#2558)" (#2…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2485
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes