Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Avoid missing conditional variable update and simplify atomic bool #2553

Merged
merged 15 commits into from
May 8, 2024

Merge branch 'main' into fix/reader_data_race

808c3c4
Select commit
Loading
Failed to load commit list.
Merged

[SDK] Avoid missing conditional variable update and simplify atomic bool #2553

Merge branch 'main' into fix/reader_data_race
808c3c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2024 in 1s

87.57% (+0.46%) compared to 497eaf4

View this Pull Request on Codecov

87.57% (+0.46%) compared to 497eaf4

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (497eaf4) to head (808c3c4).
Report is 58 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2553      +/-   ##
==========================================
+ Coverage   87.12%   87.57%   +0.46%     
==========================================
  Files         200      188      -12     
  Lines        6109     5848     -261     
==========================================
- Hits         5322     5121     -201     
+ Misses        787      727      -60     
Files Coverage Δ
.../include/opentelemetry/sdk/metrics/metric_reader.h 50.00% <ø> (ø)
...metrics/export/periodic_exporting_metric_reader.cc 79.79% <100.00%> (+0.44%) ⬆️
sdk/src/metrics/metric_reader.cc 77.42% <100.00%> (-1.36%) ⬇️

... and 55 files with indirect coverage changes