Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Rename populate_otel_scope to without_otel_scope #2479

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

timwoj
Copy link
Contributor

@timwoj timwoj commented Jan 8, 2024

Fixes #2442

Changes

This renames the recently-new populate_otel_scope option to without_otel_scope to match the related docs changes.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@timwoj timwoj requested a review from a team January 8, 2024 18:32
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@marcalff marcalff changed the title Rename populate_otel_scope to without_otel_scope [EXPORTER] Rename populate_otel_scope to without_otel_scope Jan 8, 2024
@marcalff
Copy link
Member

marcalff commented Jan 8, 2024

@timwoj I can not update this branch to merge it with main.

Please merge main -> PR branch

For later PR, there is somewhere a checkbox in the github UI to allow maintainers to write to the PR branch, when needed.

@marcalff marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (928a87c) 87.06% compared to head (323db41) 87.06%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2479   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

@marcalff marcalff merged commit f084fbc into open-telemetry:main Jan 8, 2024
46 checks passed
@timwoj timwoj deleted the rename-populate-otel-scope branch February 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prometheus Exporter] Unable to disable otel_scope_name attribute
3 participants