[SDK] Fix Observable Counters/UpDownCounters #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 87.52% 87.45% -0.06%
==========================================
Files 199 199
Lines 5981 5996 +15
==========================================
+ Hits 5234 5243 +9
- Misses 747 753 +6
|
ThomsonTan
reviewed
Sep 7, 2023
| @@ -159,7 +160,29 @@ class DefaultAggregation | |||
| new DoubleSumAggregation(nostd::get<SumPointData>(point_data))); | |||
| } | |||
| default: | |||
| return DefaultAggregation::CreateAggregation(instrument_descriptor, nullptr); | |||
| return nullptr; // won't reach here | |||
There was a problem hiding this comment.
Thanks, will look into this separately. Not a big fan of adding assert in telemetry sdk. But returning nullptr (even for unreachable code) is also not nice thing. Probaby we can return DropAggregation just to be cautious. Will create a issue to track this.
marcalff
reviewed
Sep 7, 2023
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2296
Changes
The default aggregation type was not handled properly for Observable Counter/UpDownCounter, and the issue was surfaced/evident out with non-zero initial measurement value. Have fixed the issue. Also we were missing the test for Observable UpDownCounter. Have added the test to catch this error.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes