[SDK] Add AdaptingCircularBufferCounter for exponential histograms #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 87.15% 87.48% +0.33%
==========================================
Files 166 168 +2
Lines 4777 4869 +92
==========================================
+ Hits 4163 4259 +96
+ Misses 614 610 -4
|
added 9 commits
May 25, 2023 23:14
…aware about new code
lalitb
reviewed
May 31, 2023
|
|
||
| size_t start_index_ = kNullIndex; | ||
| size_t end_index_ = kNullIndex; | ||
| size_t base_index_ = kNullIndex; |
There was a problem hiding this comment.
while these variable names are self-descriptive, can you still add a comment before each for what they represent. Thanks.
| template <typename T> | ||
| void operator()(std::vector<T> &backing) | ||
| { | ||
| std::fill(backing.begin(), backing.end(), 0); |
There was a problem hiding this comment.
you may have to typecast to static_cast<T>(0) to get rid of CI failure.
lalitb
approved these changes
May 31, 2023
marcalff
approved these changes
May 31, 2023
|
Thanks for the review.
|
added 2 commits
May 31, 2023 13:10
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1391
Changes
Add AdaptingCircularBufferCounter, which will be used for buckets in exponential histograms.
This PR is mostly a rewrite of corresponding opentelemetry-java implementation and tests.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes